Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ff132 Relnote: HTMLVideoElement.requestVideoFrameCallback + expr feat #36186

Merged

Conversation

hamishwillee
Copy link
Collaborator

FF132 ships HTMLVideoElement.requestVideoFrameCallback() and HTMLVideoElement.cancelVideoFrameCallback() in https://bugzilla.mozilla.org/show_bug.cgi?id=1919367.

This PR

  • Adds release note
  • Removes experimental feature
  • Updates the doc to match API method standard format (Description after Syntax, and definition list for argument values)

Related docs work can be tracked in #36123

@hamishwillee hamishwillee requested review from a team as code owners October 4, 2024 04:36
@hamishwillee hamishwillee requested review from pepelsbey and wbamberg and removed request for a team October 4, 2024 04:36
@github-actions github-actions bot added Content:WebAPI Web API docs Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed labels Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Preview URLs

External URLs (82)

URL: /en-US/docs/Mozilla/Firefox/Releases/132
Title: Firefox 132 for developers


URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2024-10-17 23:45:05)

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Oct 11, 2024
@hamishwillee
Copy link
Collaborator Author

@pepelsbey Can I please get a review on this?

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit 4b8a61f into mdn:main Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants