-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ff132 Relnote: HTMLVideoElement.requestVideoFrameCallback + expr feat #36186
Merged
pepelsbey
merged 4 commits into
mdn:main
from
hamishwillee:ff132_relnote_request_vidoe_frame_callback
Oct 18, 2024
Merged
Ff132 Relnote: HTMLVideoElement.requestVideoFrameCallback + expr feat #36186
pepelsbey
merged 4 commits into
mdn:main
from
hamishwillee:ff132_relnote_request_vidoe_frame_callback
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
requested review from
pepelsbey and
wbamberg
and removed request for
a team
October 4, 2024 04:36
github-actions
bot
added
Content:WebAPI
Web API docs
Content:Firefox
Content in the Mozilla/Firefox subtree
size/m
[PR only] 51-500 LoC changed
labels
Oct 4, 2024
8 tasks
This pull request has merge conflicts that must be resolved before it can be merged. |
@pepelsbey Can I please get a review on this? |
pepelsbey
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Content:Firefox
Content in the Mozilla/Firefox subtree
Content:WebAPI
Web API docs
size/m
[PR only] 51-500 LoC changed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF132 ships
HTMLVideoElement.requestVideoFrameCallback()
andHTMLVideoElement.cancelVideoFrameCallback()
in https://bugzilla.mozilla.org/show_bug.cgi?id=1919367.This PR
Related docs work can be tracked in #36123